Motschen/MidnightLib
1
0
Fork 0
mirror of https://github.com/TeamMidnightDust/MidnightLib.git synced 2025-12-15 17:05:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: improve URL handling

Browse Source 
- Uses the `open` method of `ConfirmLinkScreen` instead of manually instantiating it
- Also re-add the `requiredMod` field for `@Comment` to prevent mods that haven't adjusted yet from outright crashing
This commit is contained in:
Martin Prokoph
2025-04-18 12:37:46 +02:00
parent 4def02af12
commit e58c7fc0fd
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
common/src/main/java/eu/midnightdust/lib/config/MidnightConfig.java
View File

@@ -494,15 +494,9 @@ public abstract class MidnightConfig {
@Override @Override
public boolean mouseClicked(double mouseX, double mouseY, int button) { public boolean mouseClicked(double mouseX, double mouseY, int button) {
boolean result = super.mouseClicked(mouseX, mouseY, button); if (this.info != null && this.info.comment != null && !this.info.comment.url().isBlank())
if (this.info != null && this.info.comment != null && !this.info.comment.url().isBlank()) { ConfirmLinkScreen.open(MinecraftClient.getInstance().currentScreen, this.info.comment.url(), true);
Screen parent = MinecraftClient.getInstance().currentScreen; return super.mouseClicked(mouseX, mouseY, button);
MinecraftClient.getInstance().setScreen(new ConfirmLinkScreen((confirm)->{
if (confirm) Util.getOperatingSystem().open(this.info.comment.url());
MinecraftClient.getInstance().setScreen(parent);
}, this.info.comment.url(), true));
}
return result;
} }
public List<? extends Element> children() {return Lists.newArrayList(buttons);} public List<? extends Element> children() {return Lists.newArrayList(buttons);}
@@ -597,6 +591,7 @@ public abstract class MidnightConfig {
String category() default "default"; String category() default "default";
String name() default ""; String name() default "";
String url() default ""; String url() default "";
@Deprecated String requiredMod() default "";
} }
/** /**
* Condition Annotation<br> * Condition Annotation<br>