Compare commits

...

6 Commits

Author SHA1 Message Date
Martin Prokoph
e50128d75d chore: bump version 2025-09-27 21:52:37 +02:00
Martin Prokoph
837ead55fb build: switch to official ObsidianUI version
- Previously, I used my own build to achieve 1.21.6 compatibility
2025-09-27 21:46:26 +02:00
Martin Prokoph
c00d5893e9 Merge pull request #365 from FugLong/fix/macosLaunchCrash
fix: resolve ConcurrentModificationException in InputManager.updateBindings
2025-09-27 21:43:58 +02:00
Elijah Stephenson
af4b40e88a fix: resolve ConcurrentModificationException in InputManager.updateBindings
- Make BINDINGS list thread-safe using Collections.synchronizedList()
- Add synchronized blocks around all BINDINGS access methods
- Prevents crash on macOS clients during launch
- Fixes race condition between main thread and controller input thread
2025-09-26 20:20:51 -05:00
Martin Prokoph
994cd0d155 build: use ObsidianUI from MidnightDust maven 2025-06-21 09:30:11 +02:00
Martin Prokoph
9e4686be32 fix: get book working again with virtualkeyboard 2025-06-21 09:29:37 +02:00
10 changed files with 85 additions and 58 deletions

View File

@@ -41,7 +41,7 @@ import static eu.midnightdust.midnightcontrols.client.MidnightControlsClient.cli
*/ */
public class InputManager { public class InputManager {
public static final InputManager INPUT_MANAGER = new InputManager(); public static final InputManager INPUT_MANAGER = new InputManager();
private static final List<ButtonBinding> BINDINGS = new ArrayList<>(); private static final List<ButtonBinding> BINDINGS = Collections.synchronizedList(new ArrayList<>());
private static final List<ButtonCategory> CATEGORIES = new ArrayList<>(); private static final List<ButtonCategory> CATEGORIES = new ArrayList<>();
public static final Int2ObjectMap<ButtonState> STATES = new Int2ObjectOpenHashMap<>(); public static final Int2ObjectMap<ButtonState> STATES = new Int2ObjectOpenHashMap<>();
public static final Int2FloatMap BUTTON_VALUES = new Int2FloatOpenHashMap(); public static final Int2FloatMap BUTTON_VALUES = new Int2FloatOpenHashMap();
@@ -109,7 +109,9 @@ public class InputManager {
* @return true if the binding is registered, else false * @return true if the binding is registered, else false
*/ */
public static boolean hasBinding(@NotNull ButtonBinding binding) { public static boolean hasBinding(@NotNull ButtonBinding binding) {
return BINDINGS.contains(binding); synchronized (BINDINGS) {
return BINDINGS.contains(binding);
}
} }
/** /**
@@ -119,7 +121,9 @@ public class InputManager {
* @return true if the binding is registered, else false * @return true if the binding is registered, else false
*/ */
public static boolean hasBinding(@NotNull String name) { public static boolean hasBinding(@NotNull String name) {
return BINDINGS.parallelStream().map(ButtonBinding::getName).anyMatch(binding -> binding.equalsIgnoreCase(name)); synchronized (BINDINGS) {
return BINDINGS.parallelStream().map(ButtonBinding::getName).anyMatch(binding -> binding.equalsIgnoreCase(name));
}
} }
/** /**
@@ -139,18 +143,22 @@ public class InputManager {
* @return true if the binding is registered, else false * @return true if the binding is registered, else false
*/ */
public static ButtonBinding getBinding(@NotNull String name) { public static ButtonBinding getBinding(@NotNull String name) {
if (BINDINGS.parallelStream().map(ButtonBinding::getName).anyMatch(binding -> binding.equalsIgnoreCase(name))) synchronized (BINDINGS) {
BINDINGS.forEach(binding -> { if (BINDINGS.parallelStream().map(ButtonBinding::getName).anyMatch(binding -> binding.equalsIgnoreCase(name)))
if (binding.getName().equalsIgnoreCase(name)) InputManager.tempBinding = binding; BINDINGS.forEach(binding -> {
}); if (binding.getName().equalsIgnoreCase(name)) InputManager.tempBinding = binding;
});
}
return tempBinding; return tempBinding;
} }
private static List<ButtonBinding> unboundBindings; private static List<ButtonBinding> unboundBindings;
public static List<ButtonBinding> getUnboundBindings() { public static List<ButtonBinding> getUnboundBindings() {
unboundBindings = new ArrayList<>(); unboundBindings = new ArrayList<>();
BINDINGS.forEach(binding -> { synchronized (BINDINGS) {
if (binding.isNotBound() && !MidnightControlsConfig.ignoredUnboundKeys.contains(binding.getTranslationKey())) unboundBindings.add(binding); BINDINGS.forEach(binding -> {
}); if (binding.isNotBound() && !MidnightControlsConfig.ignoredUnboundKeys.contains(binding.getTranslationKey())) unboundBindings.add(binding);
});
}
unboundBindings.sort(Comparator.comparing(s -> I18n.translate(s.getTranslationKey()))); unboundBindings.sort(Comparator.comparing(s -> I18n.translate(s.getTranslationKey())));
return unboundBindings; return unboundBindings;
} }
@@ -162,9 +170,11 @@ public class InputManager {
* @return the registered binding * @return the registered binding
*/ */
public static @NotNull ButtonBinding registerBinding(@NotNull ButtonBinding binding) { public static @NotNull ButtonBinding registerBinding(@NotNull ButtonBinding binding) {
if (hasBinding(binding)) synchronized (BINDINGS) {
throw new IllegalStateException("Cannot register twice a button binding in the registry."); if (BINDINGS.contains(binding))
BINDINGS.add(binding); throw new IllegalStateException("Cannot register twice a button binding in the registry.");
BINDINGS.add(binding);
}
return binding; return binding;
} }
@@ -284,7 +294,9 @@ public class InputManager {
* @return true if the button has duplicated bindings, else false * @return true if the button has duplicated bindings, else false
*/ */
public static boolean hasDuplicatedBindings(int[] button) { public static boolean hasDuplicatedBindings(int[] button) {
return BINDINGS.parallelStream().filter(binding -> areButtonsEquivalent(binding.getButton(), button)).count() > 1; synchronized (BINDINGS) {
return BINDINGS.parallelStream().filter(binding -> areButtonsEquivalent(binding.getButton(), button)).count() > 1;
}
} }
/** /**
@@ -294,7 +306,9 @@ public class InputManager {
* @return true if the button has duplicated bindings, else false * @return true if the button has duplicated bindings, else false
*/ */
public static boolean hasDuplicatedBindings(ButtonBinding binding) { public static boolean hasDuplicatedBindings(ButtonBinding binding) {
return BINDINGS.parallelStream().filter(other -> areButtonsEquivalent(other.getButton(), binding.getButton()) && other.filter.equals(binding.filter)).count() > 1; synchronized (BINDINGS) {
return BINDINGS.parallelStream().filter(other -> areButtonsEquivalent(other.getButton(), binding.getButton()) && other.filter.equals(binding.filter)).count() > 1;
}
} }
/** /**
@@ -347,7 +361,8 @@ public class InputManager {
record ButtonStateValue(ButtonState state, float value) { record ButtonStateValue(ButtonState state, float value) {
} }
var states = new Object2ObjectOpenHashMap<ButtonBinding, ButtonStateValue>(); var states = new Object2ObjectOpenHashMap<ButtonBinding, ButtonStateValue>();
for (var binding : BINDINGS) { synchronized (BINDINGS) {
for (var binding : BINDINGS) {
var state = binding.isAvailable() ? getBindingState(binding) : ButtonState.NONE; var state = binding.isAvailable() ? getBindingState(binding) : ButtonState.NONE;
if (skipButtons.intStream().anyMatch(btn -> containsButton(binding.getButton(), btn))) { if (skipButtons.intStream().anyMatch(btn -> containsButton(binding.getButton(), btn))) {
if (binding.isPressed()) if (binding.isPressed())
@@ -368,6 +383,7 @@ public class InputManager {
float value = getBindingValue(binding, state); float value = getBindingValue(binding, state);
states.put(binding, new ButtonStateValue(state, value)); states.put(binding, new ButtonStateValue(state, value));
}
} }
states.forEach((binding, state) -> { states.forEach((binding, state) -> {
@@ -387,7 +403,9 @@ public class InputManager {
} }
public static @NotNull Stream<ButtonBinding> streamBindings() { public static @NotNull Stream<ButtonBinding> streamBindings() {
return BINDINGS.stream(); synchronized (BINDINGS) {
return BINDINGS.stream();
}
} }
public static @NotNull Stream<ButtonCategory> streamCategories() { public static @NotNull Stream<ButtonCategory> streamCategories() {

View File

@@ -9,18 +9,13 @@
package eu.midnightdust.midnightcontrols.client.gui; package eu.midnightdust.midnightcontrols.client.gui;
import com.mojang.blaze3d.opengl.GlStateManager;
import com.mojang.blaze3d.systems.RenderSystem;
import eu.midnightdust.midnightcontrols.MidnightControlsConstants; import eu.midnightdust.midnightcontrols.MidnightControlsConstants;
import eu.midnightdust.midnightcontrols.client.MidnightControlsClient; import eu.midnightdust.midnightcontrols.client.MidnightControlsClient;
import eu.midnightdust.midnightcontrols.client.util.platform.NetworkUtil; import eu.midnightdust.midnightcontrols.client.util.platform.NetworkUtil;
import eu.midnightdust.midnightcontrols.client.virtualkeyboard.KeyboardLayoutManager; import eu.midnightdust.midnightcontrols.client.virtualkeyboard.KeyboardLayoutManager;
import net.minecraft.client.gl.RenderPipelines;
import net.minecraft.util.math.ColorHelper; import net.minecraft.util.math.ColorHelper;
import org.thinkingstudio.obsidianui.background.Background; import org.thinkingstudio.obsidianui.background.Background;
import org.thinkingstudio.obsidianui.mixin.DrawContextAccessor;
import org.thinkingstudio.obsidianui.widget.SpruceWidget; import org.thinkingstudio.obsidianui.widget.SpruceWidget;
import eu.midnightdust.lib.util.MidnightColorUtil;
import eu.midnightdust.midnightcontrols.MidnightControls; import eu.midnightdust.midnightcontrols.MidnightControls;
import eu.midnightdust.midnightcontrols.client.MidnightControlsConfig; import eu.midnightdust.midnightcontrols.client.MidnightControlsConfig;
import eu.midnightdust.midnightcontrols.client.controller.Controller; import eu.midnightdust.midnightcontrols.client.controller.Controller;
@@ -39,18 +34,13 @@ import net.minecraft.client.MinecraftClient;
import net.minecraft.client.gui.DrawContext; import net.minecraft.client.gui.DrawContext;
import net.minecraft.client.gui.screen.Screen; import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.widget.ButtonWidget; import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.render.*;
import net.minecraft.client.resource.language.I18n; import net.minecraft.client.resource.language.I18n;
import net.minecraft.client.util.math.MatrixStack;
import net.minecraft.text.MutableText; import net.minecraft.text.MutableText;
import net.minecraft.text.Text; import net.minecraft.text.Text;
import net.minecraft.util.Formatting; import net.minecraft.util.Formatting;
import net.minecraft.util.Util; import net.minecraft.util.Util;
import org.joml.Matrix4f;
import org.lwjgl.glfw.GLFW; import org.lwjgl.glfw.GLFW;
import java.awt.*;
/** /**
* Represents the midnightcontrols settings screen. * Represents the midnightcontrols settings screen.
*/ */

View File

@@ -1,18 +1,12 @@
package eu.midnightdust.midnightcontrols.client.mixin; package eu.midnightdust.midnightcontrols.client.mixin;
import net.minecraft.client.gui.screen.ingame.BookEditScreen; import net.minecraft.client.gui.screen.ingame.BookEditScreen;
import net.minecraft.client.util.SelectionManager; import net.minecraft.client.gui.widget.EditBoxWidget;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor; import org.spongepowered.asm.mixin.gen.Accessor;
import org.spongepowered.asm.mixin.gen.Invoker;
import java.util.List;
@Mixin(BookEditScreen.class) @Mixin(BookEditScreen.class)
public interface BookEditScreenAccessor { public interface BookEditScreenAccessor {
@Accessor("pages") @Accessor("editBox")
List<String> midnightcontrols$getPages(); EditBoxWidget midnightcontrols$getEditBox();
@Accessor("currentPage")
int midnightcontrols$getCurrentPage();
} }

View File

@@ -0,0 +1,12 @@
package eu.midnightdust.midnightcontrols.client.mixin;
import net.minecraft.client.gui.screen.ingame.BookSigningScreen;
import net.minecraft.client.gui.widget.TextFieldWidget;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Accessor;
@Mixin(BookSigningScreen.class)
public interface BookSigningScreenAccessor {
@Accessor("bookTitleTextField")
TextFieldWidget midnightcontrols$getBookTitleTextField();
}

View File

@@ -6,6 +6,7 @@ import eu.midnightdust.midnightcontrols.client.virtualkeyboard.clickhandler.Defa
import eu.midnightdust.midnightcontrols.client.virtualkeyboard.clickhandler.SignEditScreenClickHandler; import eu.midnightdust.midnightcontrols.client.virtualkeyboard.clickhandler.SignEditScreenClickHandler;
import net.minecraft.client.gui.screen.Screen; import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.screen.ingame.BookEditScreen; import net.minecraft.client.gui.screen.ingame.BookEditScreen;
import net.minecraft.client.gui.screen.ingame.BookSigningScreen;
import net.minecraft.client.gui.screen.ingame.SignEditScreen; import net.minecraft.client.gui.screen.ingame.SignEditScreen;
import java.util.HashMap; import java.util.HashMap;
@@ -18,6 +19,7 @@ public class MouseClickInterceptor {
public MouseClickInterceptor() { public MouseClickInterceptor() {
this.clickHandlers = new HashMap<>(); this.clickHandlers = new HashMap<>();
this.clickHandlers.put(BookSigningScreen.class, new BookEditScreenClickHandler.Signing());
this.clickHandlers.put(BookEditScreen.class, new BookEditScreenClickHandler()); this.clickHandlers.put(BookEditScreen.class, new BookEditScreenClickHandler());
this.clickHandlers.put(SignEditScreen.class, new SignEditScreenClickHandler()); this.clickHandlers.put(SignEditScreen.class, new SignEditScreenClickHandler());
this.clickHandlers.put(Screen.class, new DefaultScreenClickHandler()); this.clickHandlers.put(Screen.class, new DefaultScreenClickHandler());

View File

@@ -1,8 +1,11 @@
package eu.midnightdust.midnightcontrols.client.virtualkeyboard.clickhandler; package eu.midnightdust.midnightcontrols.client.virtualkeyboard.clickhandler;
import eu.midnightdust.midnightcontrols.client.mixin.BookEditScreenAccessor; import eu.midnightdust.midnightcontrols.client.mixin.BookEditScreenAccessor;
import eu.midnightdust.midnightcontrols.client.mixin.BookSigningScreenAccessor;
import eu.midnightdust.midnightcontrols.client.virtualkeyboard.gui.VirtualKeyboardScreen; import eu.midnightdust.midnightcontrols.client.virtualkeyboard.gui.VirtualKeyboardScreen;
import net.minecraft.client.gui.screen.ingame.BookEditScreen; import net.minecraft.client.gui.screen.ingame.BookEditScreen;
import net.minecraft.client.gui.screen.ingame.BookSigningScreen;
import net.minecraft.client.gui.widget.EditBoxWidget;
import static eu.midnightdust.midnightcontrols.client.MidnightControlsClient.client; import static eu.midnightdust.midnightcontrols.client.MidnightControlsClient.client;
@@ -10,28 +13,35 @@ public class BookEditScreenClickHandler extends AbstractScreenClickHandler<BookE
@Override @Override
public void handle(BookEditScreen screen, double mouseX, double mouseY) { public void handle(BookEditScreen screen, double mouseX, double mouseY) {
// don't open the keyboard if a UI element was clicked // don't open the keyboard if a UI element was clicked
if(screen.hoveredElement(mouseX, mouseY).isPresent()) { if(screen.hoveredElement(mouseX, mouseY).isPresent() && !(screen.hoveredElement(mouseX, mouseY).get() instanceof EditBoxWidget)) {
return; return;
} }
var accessor = (BookEditScreenAccessor) screen; var accessor = (BookEditScreenAccessor) screen;
VirtualKeyboardScreen virtualKeyboardScreen; VirtualKeyboardScreen virtualKeyboardScreen = new VirtualKeyboardScreen(accessor.midnightcontrols$getEditBox().getText(), (text) -> {
// if(accessor.midnightcontrols$isSigning()) { client.setScreen(screen);
// virtualKeyboardScreen = new VirtualKeyboardScreen(accessor.midnightcontrols$getTitle(), (text) -> { accessor.midnightcontrols$getEditBox().setText(text);
// client.setScreen(screen); }, true);
// accessor.midnightcontrols$setTitle(text);
// }, true);
// }
// else {
virtualKeyboardScreen = new VirtualKeyboardScreen(accessor.midnightcontrols$getPages().get(accessor.midnightcontrols$getCurrentPage()), (text) -> {
client.setScreen(screen);
accessor.midnightcontrols$getPages().add(accessor.midnightcontrols$getCurrentPage(), text);
accessor.midnightcontrols$getPages().remove(accessor.midnightcontrols$getCurrentPage()+1);
//accessor.midnightcontrols$getCurrentPageSelectionManager().putCursorAtEnd();
}, true);
//}
client.setScreen(virtualKeyboardScreen); client.setScreen(virtualKeyboardScreen);
} }
public static class Signing extends AbstractScreenClickHandler<BookSigningScreen> {
@Override
public void handle(BookSigningScreen screen, double mouseX, double mouseY) {
// don't open the keyboard if a UI element was clicked
if(screen.hoveredElement(mouseX, mouseY).isPresent()) {
return;
}
var accessor = (BookSigningScreenAccessor) screen;
VirtualKeyboardScreen virtualKeyboardScreen = new VirtualKeyboardScreen(accessor.midnightcontrols$getBookTitleTextField().getText(), (text) -> {
client.setScreen(screen);
accessor.midnightcontrols$getBookTitleTextField().setText(text);
}, false);
client.setScreen(virtualKeyboardScreen);
}
}
} }

View File

@@ -7,6 +7,7 @@
"AbstractSignEditScreenMixin", "AbstractSignEditScreenMixin",
"AdvancementsScreenAccessor", "AdvancementsScreenAccessor",
"BookEditScreenAccessor", "BookEditScreenAccessor",
"BookSigningScreenAccessor",
"ChatScreenMixin", "ChatScreenMixin",
"ClickableWidgetAccessor", "ClickableWidgetAccessor",
"ClientPlayerEntityMixin", "ClientPlayerEntityMixin",

View File

@@ -24,7 +24,7 @@ dependencies {
modImplementation "net.fabricmc:fabric-loader:${rootProject.fabric_loader_version}" modImplementation "net.fabricmc:fabric-loader:${rootProject.fabric_loader_version}"
modApi "net.fabricmc.fabric-api:fabric-api:${rootProject.fabric_api_version}" modApi "net.fabricmc.fabric-api:fabric-api:${rootProject.fabric_api_version}"
modImplementation include ("maven.modrinth:midnightlib:${rootProject.midnightlib_version}-fabric") modImplementation include ("maven.modrinth:midnightlib:${rootProject.midnightlib_version}-fabric")
modImplementation include ("maven.modrinth:obsidianui:${rootProject.obsidianui_version}-fabric") {} modImplementation include ("maven.modrinth:obsidianui:${rootProject.obsidianui_version}-fabric")
include 'org.aperlambda:lambdajcommon:1.8.1' include 'org.aperlambda:lambdajcommon:1.8.1'
modCompileOnly "maven.modrinth:emi:${project.emi_version}" modCompileOnly "maven.modrinth:emi:${project.emi_version}"

View File

@@ -3,19 +3,19 @@ org.gradle.parallel=true
org.gradle.jvmargs=-Xmx2048M org.gradle.jvmargs=-Xmx2048M
minecraft_version=1.21.6 minecraft_version=1.21.6
supported_versions= supported_versions=1.21.8
yarn_mappings=1.21.6+build.1 yarn_mappings=1.21.6+build.1
enabled_platforms=fabric,neoforge enabled_platforms=fabric,neoforge
archives_base_name=midnightcontrols archives_base_name=midnightcontrols
mod_version=1.11.0 mod_version=1.11.2
maven_group=eu.midnightdust maven_group=eu.midnightdust
release_type=release release_type=release
modrinth_id = bXX9h73M modrinth_id = bXX9h73M
curseforge_id = 621768 curseforge_id = 621768
# Configure the IDs here after creating the projects on the websites # Configure the IDs here after creating the projects on the websites
midnightlib_version=1.7.4+1.21.6 midnightlib_version=1.7.5+1.21.6
fabric_loader_version=0.16.14 fabric_loader_version=0.16.14
fabric_api_version=0.127.0+1.21.6 fabric_api_version=0.127.0+1.21.6
@@ -27,7 +27,7 @@ quilt_loader_version=0.19.0-beta.18
quilt_fabric_api_version=7.0.1+0.83.0-1.20 quilt_fabric_api_version=7.0.1+0.83.0-1.20
sodium_version=mc1.21-0.6.0-beta.1 sodium_version=mc1.21-0.6.0-beta.1
obsidianui_version=0.2.11+mc1.21.5 obsidianui_version=0.2.12+mc1.21.6
modmenu_version=10.0.0-beta.1 modmenu_version=10.0.0-beta.1
emotecraft_version=2.5.5+1.21.4-fabric emotecraft_version=2.5.5+1.21.4-fabric
bendylib_version=2.0.+ bendylib_version=2.0.+

View File

@@ -41,7 +41,7 @@ configurations {
dependencies { dependencies {
neoForge "net.neoforged:neoforge:$rootProject.neoforge_version" neoForge "net.neoforged:neoforge:$rootProject.neoforge_version"
modImplementation include ("maven.modrinth:midnightlib:${rootProject.midnightlib_version}-neoforge") modImplementation include ("maven.modrinth:midnightlib:${rootProject.midnightlib_version}-neoforge")
modImplementation include ("maven.modrinth:obsidianui:${rootProject.obsidianui_version}-neoforge") {} modImplementation include ("maven.modrinth:obsidianui:${rootProject.obsidianui_version}-neoforge")
shadowBundle('org.aperlambda:lambdajcommon:1.8.1') { shadowBundle('org.aperlambda:lambdajcommon:1.8.1') {
exclude group: 'com.google.code.gson' exclude group: 'com.google.code.gson'
exclude group: 'com.google.guava' exclude group: 'com.google.guava'