From d7ea484e71e6665489f09f2f1d0f13cb54d98f82 Mon Sep 17 00:00:00 2001 From: Martin Prokoph Date: Thu, 2 Oct 2025 17:23:00 +0200 Subject: [PATCH] clean: remove double tap to sprint option Now configurable in vanilla --- .../midnightcontrols/client/MidnightControlsConfig.java | 2 -- .../client/gui/MidnightControlsSettingsScreen.java | 5 ----- .../client/mixin/ClientPlayerEntityMixin.java | 3 --- 3 files changed, 10 deletions(-) diff --git a/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsConfig.java b/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsConfig.java index 0884ec4..afcaa50 100644 --- a/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsConfig.java +++ b/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsConfig.java @@ -118,7 +118,6 @@ public class MidnightControlsConfig extends MidnightConfig { @Comment(category = GAMEPLAY, centered = true, name="\uD83D\uDECB Comfort") public static Comment _comfort; @Entry(category = GAMEPLAY, name = "Enable Hints") public static boolean enableHints = true; @Entry(category = GAMEPLAY, name = "midnightcontrols.menu.analog_movement") public static boolean analogMovement = true; - @Entry(category = GAMEPLAY, name = "midnightcontrols.menu.double_tap_to_sprint") public static boolean doubleTapToSprint = true; @Entry(category = GAMEPLAY, name = "midnightcontrols.menu.controller_toggle_sneak") public static boolean controllerToggleSneak = MinecraftClient.getInstance().options.getSneakToggled().getValue(); @Entry(category = GAMEPLAY, name = "midnightcontrols.menu.controller_toggle_sprint") public static boolean controllerToggleSprint = MinecraftClient.getInstance().options.getSprintToggled().getValue(); @@ -464,7 +463,6 @@ public class MidnightControlsConfig extends MidnightConfig { hudEnable = true; hudSide = HudSide.LEFT; analogMovement = true; - doubleTapToSprint = true; controllerToggleSneak = MinecraftClient.getInstance().options.getSneakToggled().getValue(); controllerToggleSprint = MinecraftClient.getInstance().options.getSprintToggled().getValue(); fastBlockPlacing = false; diff --git a/common/src/main/java/eu/midnightdust/midnightcontrols/client/gui/MidnightControlsSettingsScreen.java b/common/src/main/java/eu/midnightdust/midnightcontrols/client/gui/MidnightControlsSettingsScreen.java index a50bf55..7f63220 100644 --- a/common/src/main/java/eu/midnightdust/midnightcontrols/client/gui/MidnightControlsSettingsScreen.java +++ b/common/src/main/java/eu/midnightdust/midnightcontrols/client/gui/MidnightControlsSettingsScreen.java @@ -64,7 +64,6 @@ public class MidnightControlsSettingsScreen extends SpruceScreen { private final SpruceOption advancedConfigOption; // Gameplay options private final SpruceOption analogMovementOption; - private final SpruceOption doubleTapToSprintOption; private final SpruceOption autoJumpOption; private final SpruceOption controllerToggleSneakOption; private final SpruceOption controllerToggleSprintOption; @@ -228,9 +227,6 @@ public class MidnightControlsSettingsScreen extends SpruceScreen { this.analogMovementOption = new SpruceToggleBooleanOption("midnightcontrols.menu.analog_movement", () -> MidnightControlsConfig.analogMovement, value -> MidnightControlsConfig.analogMovement = value, Text.translatable("midnightcontrols.menu.analog_movement.tooltip")); - this.doubleTapToSprintOption = new SpruceToggleBooleanOption("midnightcontrols.menu.double_tap_to_sprint", - () -> MidnightControlsConfig.doubleTapToSprint, value -> MidnightControlsConfig.doubleTapToSprint = value, - Text.translatable("midnightcontrols.menu.double_tap_to_sprint.tooltip")); this.autoJumpOption = new SpruceToggleBooleanOption("options.autoJump", () -> this.client.options.getAutoJump().getValue(), newValue -> this.client.options.getAutoJump().setValue(newValue), @@ -409,7 +405,6 @@ public class MidnightControlsSettingsScreen extends SpruceScreen { var list = new SpruceOptionListWidget(Position.origin(), width, height); list.setBackground(new MidnightControlsBackground(130)); list.addSingleOptionEntry(this.analogMovementOption); - list.addSingleOptionEntry(this.doubleTapToSprintOption); list.addSingleOptionEntry(this.controllerToggleSneakOption); list.addSingleOptionEntry(this.controllerToggleSprintOption); if (MidnightControls.isExtrasLoaded) list.addSingleOptionEntry(this.fastBlockPlacingOption); diff --git a/common/src/main/java/eu/midnightdust/midnightcontrols/client/mixin/ClientPlayerEntityMixin.java b/common/src/main/java/eu/midnightdust/midnightcontrols/client/mixin/ClientPlayerEntityMixin.java index ffa352a..6119064 100644 --- a/common/src/main/java/eu/midnightdust/midnightcontrols/client/mixin/ClientPlayerEntityMixin.java +++ b/common/src/main/java/eu/midnightdust/midnightcontrols/client/mixin/ClientPlayerEntityMixin.java @@ -56,12 +56,9 @@ public abstract class ClientPlayerEntityMixin extends AbstractClientPlayerEntity @Shadow protected abstract boolean isCamera(); - @Shadow protected int ticksLeftToDoubleTapSprint; - @Inject(method = "move(Lnet/minecraft/entity/MovementType;Lnet/minecraft/util/math/Vec3d;)V", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/AbstractClientPlayerEntity;move(Lnet/minecraft/entity/MovementType;Lnet/minecraft/util/math/Vec3d;)V")) public void onMove(MovementType type, Vec3d movement, CallbackInfo ci) { - if (!MidnightControlsConfig.doubleTapToSprint) ticksLeftToDoubleTapSprint = 0; if (!MidnightControls.isExtrasLoaded) return; if (type == MovementType.SELF) { if (this.getAbilities().flying && (!MidnightControlsConfig.flyDrifting || !MidnightControlsConfig.verticalFlyDrifting)) {