diff --git a/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsClient.java b/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsClient.java index 35576a3..e027ff9 100644 --- a/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsClient.java +++ b/common/src/main/java/eu/midnightdust/midnightcontrols/client/MidnightControlsClient.java @@ -56,16 +56,17 @@ import java.util.concurrent.atomic.AtomicReference; */ public class MidnightControlsClient extends MidnightControls { public static boolean lateInitDone = false; + public static final KeyBinding.Category MIDNIGHTCONTROLS_CATEGORY = KeyBinding.Category.create(Identifier.of("midnightcontrols", "keybinds")); public static final KeyBinding BINDING_LOOK_UP = InputManager.makeKeyBinding(id("look_up"), - InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_8, "key.categories.midnightcontrols"); + InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_8, MIDNIGHTCONTROLS_CATEGORY); public static final KeyBinding BINDING_LOOK_RIGHT = InputManager.makeKeyBinding(id("look_right"), - InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_6, "key.categories.midnightcontrols"); + InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_6, MIDNIGHTCONTROLS_CATEGORY); public static final KeyBinding BINDING_LOOK_DOWN = InputManager.makeKeyBinding(id("look_down"), - InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_2, "key.categories.midnightcontrols"); + InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_2, MIDNIGHTCONTROLS_CATEGORY); public static final KeyBinding BINDING_LOOK_LEFT = InputManager.makeKeyBinding(id("look_left"), - InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_4, "key.categories.midnightcontrols"); + InputUtil.Type.KEYSYM, GLFW.GLFW_KEY_KP_4, MIDNIGHTCONTROLS_CATEGORY); public static final KeyBinding BINDING_RING = InputManager.makeKeyBinding(id("ring"), - InputUtil.Type.KEYSYM, InputUtil.UNKNOWN_KEY.getCode(), "key.categories.midnightcontrols"); + InputUtil.Type.KEYSYM, InputUtil.UNKNOWN_KEY.getCode(), MIDNIGHTCONTROLS_CATEGORY); public static final Identifier CONTROLLER_BUTTONS = id("textures/gui/controller_buttons.png"); public static final Identifier CONTROLLER_EXPANDED = id("textures/gui/controller_expanded.png"); public static final Identifier CONTROLLER_AXIS = id("textures/gui/controller_axis.png"); diff --git a/common/src/main/java/eu/midnightdust/midnightcontrols/client/controller/InputManager.java b/common/src/main/java/eu/midnightdust/midnightcontrols/client/controller/InputManager.java index 51742c6..9815982 100644 --- a/common/src/main/java/eu/midnightdust/midnightcontrols/client/controller/InputManager.java +++ b/common/src/main/java/eu/midnightdust/midnightcontrols/client/controller/InputManager.java @@ -420,18 +420,9 @@ public class InputManager { * @param code the code * @param category the category of the key binding * @return the key binding - * @see #makeKeyBinding(Identifier, InputUtil.Type, int, String) + * @see #makeKeyBinding(Identifier, InputUtil.Type, int, net.minecraft.client.option.KeyBinding.Category) */ - public static @NotNull KeyBinding makeKeyBinding(@NotNull Identifier id, InputUtil.Type type, int code, @NotNull String category) { - return new KeyBinding(String.format("key.%s.%s", id.getNamespace(), id.getPath()), type, code, new KeyBinding.Category(validVanillaId(category))); - } - - private static Identifier validVanillaId(String path) { - for(int i = 0; i < path.length(); ++i) { - if (!Identifier.isPathCharacterValid(path.charAt(i))) { - path = path.replace(path.charAt(i), '_'); - } - } - return Identifier.ofVanilla(path); + public static @NotNull KeyBinding makeKeyBinding(@NotNull Identifier id, InputUtil.Type type, int code, @NotNull KeyBinding.Category category) { + return new KeyBinding(String.format("key.%s.%s", id.getNamespace(), id.getPath()), type, code, category); } } diff --git a/common/src/main/resources/assets/midnightcontrols/lang/en_us.json b/common/src/main/resources/assets/midnightcontrols/lang/en_us.json index 6b1b3c7..c338c17 100644 --- a/common/src/main/resources/assets/midnightcontrols/lang/en_us.json +++ b/common/src/main/resources/assets/midnightcontrols/lang/en_us.json @@ -23,7 +23,7 @@ "midnightcontrols.midnightconfig.enum.TouchMode.FINGER_POS": "Finger Position", "midnightcontrols.midnightconfig.enum.CameraMode.FLAT": "Flat", "midnightcontrols.midnightconfig.enum.CameraMode.ADAPTIVE": "Adaptive", - "key.categories.midnightcontrols": "MidnightControls", + "key.category.midnightcontrols.keybinds": "MidnightControls", "key.midnightcontrols.look_down": "Look Down", "key.midnightcontrols.look_left": "Look Left", "key.midnightcontrols.look_right": "Look Right",